Re: [PATCH] change b_size to size_t

From: Benjamin LaHaise
Date: Thu Feb 23 2006 - 12:32:10 EST


On Thu, Feb 23, 2006 at 09:28:58AM -0800, Badari Pulavarty wrote:
> How about doing this ? Change b_state to u32 and change b_size
> to "size_t". This way, we don't increase the overall size of
> the structure on 64-bit machines. Isn't it ?

I was thinking of that too, but that doesn't work with the bit operations
on big endian machines (which require unsigned long). Oh well, I guess
that even with adding an extra 8 bytes on x86-64 we're still at the 96
bytes, or 92 bytes if the atomic_t is put at the end of the struct.

-ben
--
"Ladies and gentlemen, I'm sorry to interrupt, but the police are here
and they've asked us to stop the party." Don't Email: <dont@xxxxxxxxx>.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/