Re: cannot open initial console

From: Chris Wright
Date: Thu Feb 23 2006 - 02:04:23 EST


* Matheus Izvekov (mizvekov@xxxxxxxxx) wrote:
> On 2/23/06, Matheus Izvekov <mizvekov@xxxxxxxxx> wrote:
> > On 2/22/06, Matheus Izvekov <mizvekov@xxxxxxxxx> wrote:
> > } else if (le32_to_cpu(rs->s_flags) & reiserfs_attrs_cleared) {
> > - REISERFS_SB(s)->s_mount_opt |= REISERFS_ATTRS;
> > + REISERFS_SB(s)->s_mount_opt |= (1 << REISERFS_ATTRS);
> > }
> > }
> >
> > Reversing this fixes the problem, double checked it. What was that
> > patch supposed to do anyway?
>
> Adding Vitaly Fertman to this thread, as he is the one who seems to
> have submitted that patch.

It's attempting to properly automatically enable a reiserfs feature
supporting attributes (via chattr/lsattr interface). When mounting
(w/out attrs mount option) a reiserfs that should support attrs, the
above patch fixes the value OR'd with s_mount_opt (which was incorrectly
the shift value rather than the shifted value). This has been backed
out in current -stable queue, and was fixed in Linus' tree as well.

thanks,
-chris

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/