[PATCH 4/6] de_thread: don't take tasklist_lock

From: Oleg Nesterov
Date: Wed Feb 22 2006 - 18:07:04 EST


de_thread() takes tasklist_lock for zap_other_threads(),
this is unneeded now.

Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

--- 2.6.16-rc3/fs/exec.c~4_DET 2006-02-18 01:12:36.000000000 +0300
+++ 2.6.16-rc3/fs/exec.c 2006-02-23 01:59:12.000000000 +0300
@@ -604,7 +604,6 @@ static int de_thread(struct task_struct
* Kill all other threads in the thread group.
* We must hold tasklist_lock to call zap_other_threads.
*/
- read_lock(&tasklist_lock);
spin_lock_irq(lock);
if (sig->flags & SIGNAL_GROUP_EXIT) {
/*
@@ -612,12 +611,10 @@ static int de_thread(struct task_struct
* return so that the signal is processed.
*/
spin_unlock_irq(lock);
- read_unlock(&tasklist_lock);
kmem_cache_free(sighand_cachep, newsighand);
return -EAGAIN;
}
zap_other_threads(current);
- read_unlock(&tasklist_lock);

/*
* Account for the thread group leader hanging around:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/