Re: *** Announcement: dmraid 1.0.0.rc10 ***

From: Heinz Mauelshagen
Date: Wed Feb 22 2006 - 04:00:03 EST


On Tue, Feb 21, 2006 at 05:10:26PM +0100, Thierry Vignaud wrote:
> Heinz Mauelshagen <mauelshagen@xxxxxxxxxx> writes:
>
> > *** Announcement: dmraid 1.0.0.rc10 ***
> >
> > dmraid 1.0.0.rc10 is available at
> > http://people.redhat.com/heinzm/sw/dmraid/ in source tarball,
> > source rpm and i386 rpm (with shared and static binary).
> >
> > This release adds support for Adaptec HostRAID and JMicron JMB36X
> > (see CHANGELOG below for more information).
>
> you're missusing AC_ARG_ENABLE: it cannot assume whereas you want to
> default to --enable-XXX or --disable-XXX.
>
> eg passing --disable-selinux to dmraid's configures make it actually
> enable selinux support :-(

Well, I better tested --disable-libselinux rather than just leaving
the respective option out or configure --enable-libselinux, which most people
will do anyway ;-)

>
> the format is "AC_ARG_ENABLE(name, help, [ use given value ], [ default action ])"
>
> the following patch fixes it:

Applied.

>
> you might want to alter default values then since i guess you
> misunderstood what the arguments should have been.

Hrm, configure option got added last minute.

Thanks,
Heinz

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Heinz Mauelshagen Red Hat GmbH
Consulting Development Engineer Am Sonnenhang 11
Cluster and Storage Development 56242 Marienrachdorf
Germany
Mauelshagen@xxxxxxxxxx +49 2626 141200
FAX 924446
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/