Re: don't bother users with unimportant messages.

From: Dave Jones
Date: Sun Feb 19 2006 - 04:51:06 EST


On Sun, Feb 19, 2006 at 09:31:06AM +0000, Russell King wrote:
> On Sun, Feb 19, 2006 at 03:29:16AM -0500, Dave Jones wrote:
> > On Sun, Feb 19, 2006 at 08:15:23AM +0000, Russell King wrote:
> > > On Sat, Feb 18, 2006 at 08:09:10PM -0500, Dave Jones wrote:
> > > > When users see these printed to the console, they think
> > > > something is wrong. As it's just informational and something
> > > > that only developers care about, lower the printk level.
> > >
> > > If you're getting complaints about this, wouldn't it be better to
> > > forward them here so that they can be fixed up?
> >
> > w83627hf, and probably other drivers from drivers/hwmon/
>
> I don't see it - w83627hf registers w83627hf_driver via i2c_isa_add_driver,
> which does not have any probe, remove or shutdown methods. Moreover,
> i2c_isa_add_driver doesn't set any of these methods. So how can:
>
> if ((drv->bus->probe && drv->probe) ||
> (drv->bus->remove && drv->remove) ||
> (drv->bus->shutdown && drv->shutdown)) {
>
> be true?

Beats me. I'll put some printk's in there, and see what falls out.

> Local distro modifications maybe?

Nope. drivers/hwmon & drivers/i2c is untouched.

Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/