Re: [PATCH 08/12] hrtimer: completely remove it_real_value

[George Anzinger]

Roman Zippel wrote:
> Hi,
>
> On Tue, 14 Feb 2006, George Anzinger wrote:
>
>
> > > Remove the it_real_value from /proc/*/stat, during 1.2.x was the last
> > > time it returned useful data (as it was directly maintained by the
> > > scheduler), now it's only a waste of time to calculate it.
> >
> > This may be true but this changes the order of items presented making any
> > "code" looking for items after it_real_value in the list look at the wrong
> > thing.  If we are going to change this, I think we need some sort of version
> > in the output.  Something that changes when ever the output format or content
> > is modified in any way.
>
>
> I think you missed this:
>
>
> > > @@ -413,7 +411,7 @@ static int do_task_stat(struct task_stru
> > > 	start_time = nsec_to_clock_t(start_time);
> > >  	res = sprintf(buffer,"%d (%s) %c %d %d %d %d %d %lu %lu \
> > > -%lu %lu %lu %lu %lu %ld %ld %ld %ld %d %ld %llu %lu %ld %lu %lu %lu %lu %lu
> > > \
> > > +%lu %lu %lu %lu %lu %ld %ld %ld %ld %d 0 %llu %lu %ld %lu %lu %lu %lu %lu \
>
>                                             ^
I think you are right.  Looks ok to me.

--
George Anzinger   george@xxxxxxxxxxxxxxxxxxx
HRT (High-res-timers):  http://sourceforge.net/projects/high-res-timers/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/