Re: 2.6.16-rc3-mm1

[Con Kolivas]

On Wednesday 15 February 2006 07:28, Andrew Morton wrote:
> Brice Goglin <Brice.Goglin@xxxxxxxxxxxx> wrote:
> > Andrew Morton wrote:
> > >ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc3
> > >/2.6.16-rc3-mm1/
> >
> > Hi Andrew,
> >
> > WARNING: speedstep-centrino.ko needs unknown symbol cpu_online_map
> >
> > This symbol is in include/linux/cpumask.h but actually only defined and
> > exported in smpboot.c which is not compiled on UP.
>
> diff -puN
> arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c~git-acpi-up-fix-2
> arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c ---
> devel/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c~git-acpi-up-fix-2	2
>006-02-14 12:27:41.000000000 -0800 +++
> devel-akpm/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c	2006-02-14
> 12:27:41.000000000 -0800 @@ -654,8 +654,10 @@ static int centrino_target
> (struct cpufr
>  		return -EINVAL;
>  	}
>
> +#ifdef CONFIG_SMP
>  	/* cpufreq holds the hotplug lock, so we are safe from here on */
>  	cpus_and(online_policy_cpus, cpu_online_map, policy->cpus);
> +#endif

Shouldn't the cpu_online_map be hardcoded to the first/only cpu on UP instead?

Cheers,
Con
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/