Re: [PATCH] tty reference count fix

From: Arjan van de Ven
Date: Tue Feb 14 2006 - 16:44:33 EST



>
> patch looks good to me. Or you could even drop the tty_sem completely from
> the release_dev path (patch below) since lock_kernel() is held in both
> tty_open() and the release_dev paths() (and there is no sleeping b/w
> setting the tty_closing flag and setting the TTY_CLOSING bit).


that's the wrong direction.. the idea is to first put new locking under
the BKL layer.. and at the end pull the BKL entirely.. The BKL isn't a
good lock.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/