Re: [PATCH] Add cast to __iomem pointer in scsi drivers

From: Takashi Iwai
Date: Tue Feb 14 2006 - 16:12:29 EST


At Tue, 14 Feb 2006 21:05:38 +0000,
Al Viro wrote:
>
> On Tue, Feb 14, 2006 at 09:59:05PM +0100, Takashi Iwai wrote:
> > Yes, that'll be the best solution. But, in these drivers, the same
> > struct fields are used for both inl() and writel() depending on the
> > flag, so you cannot change the type.
> >
> > Hm, looks like I hit a dreadful case without a good solution.
>
> ioread*/iowrite*

Ah, that's it. Thanks.

So, the right fix is to rewrite struct ata_ioport to use iomem
pointers and all accessses to ioread*/iowrite*() ?
OK, it's a longer way to go :)


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/