Re: [trivial PATCH] "drivers/usb/media/stv680.h": fix jiffies timeout

[Nishanth Aravamudan]

On 14.02.2006 [16:33:12 +0100], Paolo Ornati wrote:
> From: Paolo Ornati <ornati@xxxxxxxxxxxxx>
> 
> stv680.c driver calls "usb_control_msg" passing PENCAM_TIMEOUT as
> jiffies timout. However PENCAM_TIMEOUT is defined to the fixed value of
> 1000, this leads to different timeouts with different HZ settings.
> 
> Since stv680.c is there since 2.4.18 I don't know if 1000 means 10s or
> 1s... I've picked the bigger.

NACK. PENCAM_TIMEOUT is a *milliseconds* timeout value.

>From the comment for usb_control_msg:

 *      @timeout: time in msecs to wait for the message to complete before
 *              timing out (if 0 the wait is forever)

Milliseconds do not depend on HZ in anyway.

Thanks,
Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/