Re: calibrate_migration_costs takes ages on s390

From: Ingo Molnar
Date: Tue Feb 14 2006 - 07:37:26 EST



* Ingo Molnar <mingo@xxxxxxx> wrote:

> * Heiko Carstens <heiko.carstens@xxxxxxxxxx> wrote:
>
> > --- a/arch/s390/lib/delay.c
> > +++ b/arch/s390/lib/delay.c
> > @@ -30,7 +30,7 @@ void __delay(unsigned long loops)
> > */
> > __asm__ __volatile__(
> > "0: brct %0,0b"
> > - : /* no outputs */ : "r" (loops/2) );
> > + : /* no outputs */ : "r" ((loops/2) + 1));
> > }
>
> ahh ... that explains the delays indeed!

just to make sure, i've checked all the other __delay() implementations
in the kernel, and none seems to have such problems.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/