[PATCH] Fix NULL pointer dereference in isdn_tty_at_cout

[Karsten Keil]

The changes in the tty related code introduced wrong parenthesis in a
if condition in the isdn_tty_at_cout function.
This caused access to index -1 in the dev->drv[] array.
This patch change it back to the correct condition from the previous
versions.

Signed-off-by: Karsten Keil <kkeil@xxxxxxx>

---

 drivers/isdn/i4l/isdn_tty.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

f472fc1267e4975379b7566b1236b9235aaeeda0
diff --git a/drivers/isdn/i4l/isdn_tty.c b/drivers/isdn/i4l/isdn_tty.c
index f190a99..3936336 100644
--- a/drivers/isdn/i4l/isdn_tty.c
+++ b/drivers/isdn/i4l/isdn_tty.c
@@ -2359,8 +2359,8 @@ isdn_tty_at_cout(char *msg, modem_info *
 
 	/* use queue instead of direct, if online and */
 	/* data is in queue or buffer is full */
-	if ((info->online && tty_buffer_request_room(tty, l) < l) ||
-	    (!skb_queue_empty(&dev->drv[info->isdn_driver]->rpqueue[info->isdn_channel]))) {
+	if (info->online && ((tty_buffer_request_room(tty, l) < l) ||
+	    !skb_queue_empty(&dev->drv[info->isdn_driver]->rpqueue[info->isdn_channel]))) {
 		skb = alloc_skb(l, GFP_ATOMIC);
 		if (!skb) {
 			spin_unlock_irqrestore(&info->readlock, flags);

-- 
Karsten Keil
SuSE Labs
ISDN development
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/