Re: madvise MADV_DONTFORK/MADV_DOFORK

[Linus Torvalds]

On Mon, 13 Feb 2006, Michael S. Tsirkin wrote:
> 
> Add madvise options to control whether memory range is inherited across fork.
> Useful e.g. for when hardware is doing DMA from/into these pages.
> 
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxxxxxx>
>
> -		if (mpnt->vm_flags & VM_DONTCOPY) {
> +		if (mpnt->vm_flags & (VM_DONTCOPY | VM_DONTFORK)) {

Why?

That VM_DONTCOPY _is_ DONTFORK. 

Don't add a new useless DONTFORK that doesn't have any value.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/