Re: Fix s390 build failure.

From: Linus Torvalds
Date: Fri Feb 10 2006 - 16:12:44 EST




On Fri, 10 Feb 2006, Dave Jones wrote:
>
> arch/s390/kernel/compat_signal.c:199: error: conflicting types for 'do_sigaction'
> include/linux/sched.h:1115: error: previous declaration of 'do_sigaction' was here
>
> Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
>
> --- linux-2.6.15.noarch/arch/s390/kernel/compat_signal.c~ 2006-02-10 12:47:57.000000000 -0500
> +++ linux-2.6.15.noarch/arch/s390/kernel/compat_signal.c 2006-02-10 12:48:05.000000000 -0500
> @@ -196,7 +196,7 @@ sys32_sigaction(int sig, const struct ol
> }
>
> int
> -do_sigaction(int sig, const struct k_sigaction *act, struct k_sigaction *oact);
> +do_sigaction(int sig, struct k_sigaction *act, struct k_sigaction *oact);

Umm. Shouldn't we just _remove_ the incorrect and unnecessary
extra declaration?

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/