Re: Cleanup possibility in asm-i386/string.h

From: Andi Kleen
Date: Fri Feb 10 2006 - 08:51:15 EST


On Friday 10 February 2006 14:02, Roman Zippel wrote:
> Hi,
>
> On Fri, 10 Feb 2006, Andi Kleen wrote:
>
> > > I remember playing with using more gcc builtins in the kernel some time
> > > ago, and some gcc builtin used a different library function, which was a
> > > function the kernel did not supply.
> >
> > It works fine on x86-64. If something is missing it can be also supplied.
>
> I think I now see what the real problem was, x86-64 does:
>
> #define strcpy __builtin_strcpy
>
> which also renames the version in lib/string.c, so x86-64 never had a
> fallback copy for __builtin_sprintf.
> Can we please get rid of -freestanding and fix x86-64 instead?

Ok I can fix that. Just removing the defines should be ok i guess
(afaik gcc detects them automatically as the builtin)

I don't know if the freestanding in the main Makefile isn't needed
for other architectures so I won't touch it right now.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/