Re: [PATCH] block: kill not-so-popular simple flag testing macros
From: Jeff Garzik
Date: Thu Feb 09 2006 - 20:17:51 EST
Tejun Heo wrote:
The code he was talking about looks like.
if (rq->flags & (REQ_SOFTBARRIER | REQ_HARDBARRIER) {
Yes, I certainly agree you don't want to test the same variable multiple
times, if you are just testing bits in the same variable.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/