Re: [PATCH] fstatat64 support

From: Christoph Hellwig
Date: Wed Feb 08 2006 - 15:38:19 EST


On Wed, Feb 08, 2006 at 03:08:39PM -0500, Ulrich Drepper wrote:
> The *at patches introduced fstatat and, due to inusfficient research, I
> used the newfstat functions generally as the guideline. The result is
> that on 32-bit platforms we don't have all the information needed to
> implement fstatat64.
>
> This patch modifies the code to pass up 64-bit information if
> __ARCH_WANT_STAT64 is defined. I renamed the syscall entry point to
> make this clear. Other archs will continue to use the existing code.
> On x86-64 the compat code is implemented using a new sys32_ function.
> this is what is done for the other stat syscalls as well.
>
>
> This patch might break some other archs (those which define
> __ARCH_WANT_STAT64 and which already wired up the syscall). Yet
> others might need changes to accomodate the compatibility mode.
> I really don't want to do that work because all this stat handling
> is a mess (more so in glibc, but the kernel is also affected). It
> should be done by the arch maintainers. I'll provide some
> stand-alone test shortly. Those who are eager could compile glibc
> and run 'make check' (no installation needed).

please remove the new from the syscall name. just sys_fstatat64

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/