Re: [Xen-devel] Re: [PATCH 2.6.12.6-xen] sysfs attributes for xen

From: Greg KH
Date: Mon Jan 30 2006 - 12:24:57 EST


On Mon, Jan 30, 2006 at 12:17:17PM -0500, Mike D. Day wrote:
> Dave Hansen wrote:
> >In the final version, there will be available Xen headers, and the patch
> >won't need the open-coded 1024?
>
> Good question, I need some advice. The Xen hcall headers get soft-linked
> into every paravirtualized OS tree: linux, bsd, solaris, etc. In linux
> right now the xen version.h shows up as /include/asm-xen/version.h.
>
> This file uses typedefs for every important parameter. For example, typedef
> char [1024] xen_capabilities_info_t;.
> But as Greg says TYPEDEFS ARE EVIL.

Then just make it a structure. All the operating systems will be able
to handle that just fine :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/