Re: [patch 3/4] net: Percpufy frequently used variables -- proto.sockets_allocated

From: Benjamin LaHaise
Date: Sat Jan 28 2006 - 20:22:33 EST


On Sat, Jan 28, 2006 at 04:55:49PM -0800, Andrew Morton wrote:
> local_t isn't much use until we get rid of asm-generic/local.h. Bloaty,
> racy with nested interrupts.

The overuse of atomics is horrific in what is being proposed. All the
major architectures except powerpc (i386, x86-64, ia64, and sparc64)
implement local_t. It would make far more sense to push the last few
stragglers (which mostly seem to be uniprocessor) into writing the
appropriate implementations. Perhaps it's time to add a #error in
asm-generic/local.h?

-ben
--
"Ladies and gentlemen, I'm sorry to interrupt, but the police are here
and they've asked us to stop the party." Don't Email: <dont@xxxxxxxxx>.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/