Re: [PATCH 01/04] Add multi-precision-integer maths library

From: David Härdeman
Date: Wed Jan 25 2006 - 15:44:59 EST


On Tue, Jan 24, 2006 at 10:37:47AM +0000, David Howells wrote:
David Härdeman <david@xxxxxxxx> wrote:

Adds the multi-precision-integer maths library which was originally taken
from GnuPG and ported to the kernel by David Howells in 2004
(http://people.redhat.com/~dhowells/modsign/modsign-269rc4mm1-2.diff.bz2)

You should update these files from a latest Fedora, Rawhide or RHEL kernel to
pick up the bug fixes that have been made.

Somewhat confusing...I downloaded kernel-2.6.15-1.1871_FC5.src.rpm and extracted linux-2.6-modsign-mpilib.patch from the srpm. After diffing the mpi dirs created by the previously mentioned patch and that from the Fedora kernel I get:

(david@austin:~/src/kernel/div)$ diff -Nurbw linux-2.6.9-rc4-mm1/crypto/mpi/ linux-902/crypto/mpi/
diff -Nurbw linux-2.6.9-rc4-mm1/crypto/mpi/mpi-div.c linux-902/crypto/mpi/mpi-div.c
--- linux-2.6.9-rc4-mm1/crypto/mpi/mpi-div.c 2006-01-24 22:56:09.000000000 +0100
+++ linux-902/crypto/mpi/mpi-div.c 2006-01-24 22:55:18.000000000 +0100
@@ -101,7 +101,7 @@
MPI temp_divisor = NULL;

if( quot == divisor || rem == divisor ) {
- if (mpi_copy( &temp_divisor, divisor ) < 0);
+ if (mpi_copy( &temp_divisor, divisor ) < 0)
return -ENOMEM;
divisor = temp_divisor;
}

Was that all the difference there was or am I missing something?

Re,
David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/