Re: pppd oopses current linu's git tree on disconnect

[Paul Fulghum]

Alan Cox wrote:
> Yeah the new tty code assumed the same locking rules as the old tty code
> and nobody on the planet followed them since 2.2.

I could not find any code that used the tty read_lock
when pushing data. So at least its a clean start.

> I think you've been reading my mind, only you've actually come up with a
> slightly neater variant than I have half coded here.

OK, good.

> > int tty_prepare_flip_string(struct tty_struct *tty, unsigned char **chars, size_t size)
> > {
> > 	int space = tty_buffer_request_room(tty, size);
> > -	struct tty_buffer *tb = tty->buf.tail;
> > -	*chars = tb->char_buf_ptr + tb->used;
> > -	memset(tb->flag_buf_ptr + tb->used, TTY_NORMAL, space);
> > -	tb->used += space;
> > +	if (space) {
> > +		struct tty_buffer *tb = tty->buf.tail;
> > +		*chars = tb->char_buf_ptr + tb->used;
> > +		memset(tb->flag_buf_ptr + tb->used, TTY_NORMAL, space);
> > +		tb->used += space;
> > +	}

Unrelated, yes.
But if space == 0 then tty->buf.tail could be NULL
Touching tb could oops. I think you already do a similar
check in tty_insert_flip_string() etc.

> > static inline void con_schedule_flip(struct tty_struct *t)
>
> Should die as a duplicate by the look of it, and the tty one probably
> should cease to be inline.

The only difference seems to be schedule_delayed_work()
in tty_schedule_flip() vs schedule_work() in con_schedule_flip().

All three:
tty_schedule_flip()
con_schedule_flip()
tty_flip_buffer_push()
seem to be duplicates other than that.

> Looks good to me.

There is still the esp and cyclades driver which
schedule the buf.work directly which need to be
switched to one of the above 3 functions.

I also found a case where the active flag
is not cleared correctly. (when a partial buffer is
filled and a new tail buffer is allocated before
calling one of the schedule functions.

I'll fix both of these up tomorrow, post a new
patch and continue testing.

Thanks,
Paul

--
Paul Fulghum
Microgate Systems, Ltd
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/