Re: [PATCH 10/16] make VP-3054 Secondary I2C Bus Support a Kconfig option.

From: Adrian Bunk
Date: Mon Jan 23 2006 - 19:11:43 EST

On Mon, Jan 23, 2006 at 06:06:28PM -0500, Mike Krufky wrote:
> Adrian Bunk wrote:
>
> >On Mon, Jan 23, 2006 at 06:24:44PM -0200, mchehab@xxxxxxxxxxxxx wrote:
> >...
> >>@@ -70,6 +71,16 @@ config VIDEO_CX88_DVB_MT352
> >> This adds DVB-T support for cards based on the
> >> Connexant 2388x chip and the MT352 demodulator.
> >>
> >>+config VIDEO_CX88_VP3054
> >>+ tristate "VP-3054 Secondary I2C Bus Support"
> >>+ default m
> >>...
> >>
> >>
> >This option should be a bool since "m" doesn't make much sense (it's
> >anyways interpreted the same as "y").
> >
> >
> Adrian,
>
> You have a point - it is a boolean choice yes/no, about whether or not
> to compile support for this module, ... but it is in fact a module, and
> when M is chosen, cx88-vp3054-i2c.ko will build as a module. When Y is

I don't see this in your patches.

All your patches do is to define -DHAVE_VP3054_I2C=1 depending on
CONFIG_VIDEO_CX88_VP3054.

> chosen, it will be built in-kernel, just as all other tri-states.....
> The difference is that this module depends on DVB_MT352 ... if DVB_MT352
> is M, then this should be M/N ... if VIDEO_CX88_DVB is Y, then this
> should be Y/N...
>...


If VIDEO_CX88_DVB (and modules support enabled in the kernel) this
will be Y/M/N...


A more general question:
Why are you using the indirection through the defines in the Makefile?
You could diectly use the (boolean) CONFIG_* options in the drivers.


> :-)
>
> Regards,
> Michael Krufky

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/