Re: [PATCH] slab: Adds two missing kmalloc() checks.

From: Arjan van de Ven
Date: Mon Jan 23 2006 - 11:43:38 EST


On Mon, 2006-01-23 at 18:38 +0200, Pekka Enberg wrote:
> Hi,
>
> On Mon, 2006-01-23 at 13:31 -0200, Luiz Fernando Capitulino wrote:
> > Adds two missing kmalloc() checks in kmem_cache_init(). The check is worth
> > because if kmalloc() fails we'll have a nice message instead of a OOPS (which
> > will make us look for a bug).
> >
> > We're using BUG_ON() so that embedded people can disable it.
> >
> > Signed-off-by: Luiz Capitulino <lcapitulino@xxxxxxxxxxxxxxx>
>
> Looks good to me. Arjan, you had some objections last time around. Are
> you okay with the change?

I still fail to see the point. Has anyone EVER seen these trigger????


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/