Re: [PATCH] e1000 C style badness

[Jesse Brandeburg]

On 1/19/06, Jens Axboe <axboe@xxxxxxx> wrote:
> On Wed, Jan 18 2006, Jesse Brandeburg wrote:
> > just FYI, I have a patch for the e1000 breakage which will be out as
> > soon as I can generate it.
>
> Newest -git works for me. Well sort of, I get a lot of these:
>
> e1000: eth0: e1000_watchdog_task: NIC Link is Up 1000 Mbps Full Duplex
> e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang
>   Tx Queue             <0>
>   TDH                  <72>
>   TDT                  <e5>
>   next_to_use          <e5>
>   next_to_clean        <6f>
> buffer_info[next_to_clean]
>   time_stamp           <10000160a>
>   next_to_watch        <72>
>   jiffies              <100001e09>
>   next_to_watch.status <0>
> e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang
>   Tx Queue             <0>
>   TDH                  <72>
>   TDT                  <e5>
>   next_to_use          <e5>
>   next_to_clean        <6f>
> buffer_info[next_to_clean]
>   time_stamp           <10000160a>
>   next_to_watch        <72>
>   jiffies              <1000025da>
>   next_to_watch.status <0>
> e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang
>   Tx Queue             <0>
>   TDH                  <72>
>   TDT                  <e5>
>   next_to_use          <e5>
>   next_to_clean        <6f>
> buffer_info[next_to_clean]
>   time_stamp           <10000160a>
>   next_to_watch        <72>
>   jiffies              <10000357b>
>   next_to_watch.status <0>
> NETDEV WATCHDOG: eth0: transmit timed out
> e1000: eth0: e1000_watchdog_task: NIC Link is Up 1000 Mbps Full Duplex

where it didn't happen with the previous driver?  I guess thats a good
thing, kinda as we made the problem more frequent, hopefully we can
help fix it?

you don't happen to have TSO enabled do you?

please reply over at netdev at vger.kernel.org with the standard set
of information, lspci, dmesg, etc etc.

Thanks,
  Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/