Re: [bug] __meminit breaks cpu hotplug

[Ashok Raj]

On Fri, Jan 20, 2006 at 05:27:09PM -0800, Ravikiran G Thirumalai wrote:
> 
> 
>    I hit the bug on pageset_cpuup_callback, which is obviously __cpuinit,
>    but
>    has been marked __meminit.  Yeah .. bad patch duh!
> 
>    For  some  reason  I thought all other functions marked with __meminit
>    looked
>    like  __cpuinit candidates....while just pageset_cpuup_callback should
>    be
>    changed to __cpuinit
> 

Sorry i missed this while posting the other patch. There are other functions 
called by process_zones() from withing pageset_cpuup_callback() that
are also marked __meminit. I sent a patch just now to cover that.

but as i mentioned i still have trouble getting cpuup to work right.
cpu_down() seems to work ok so far.

-- 
Cheers,
Ashok Raj
- Open Source Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/