RE: My vote against eepro* removal

From: kus Kusche Klaus
Date: Fri Jan 20 2006 - 06:26:21 EST


From: Evgeniy Polyakov
> Just a hack:
>
> --- drivers/net/e100.c.1 2006-01-20 13:39:19.000000000 +0300
> +++ drivers/net/e100.c 2006-01-20 14:15:40.000000000 +0300
> @@ -879,8 +879,8 @@
>
> writel((reg << 16) | (addr << 21) | dir | data,
> &nic->csr->mdi_ctrl);
>
> - for(i = 0; i < 100; i++) {
> - udelay(20);
> + for(i = 0; i < 1000; i++) {
> + udelay(2);
> if((data_out = readl(&nic->csr->mdi_ctrl)) & mdi_ready)
> break;
> }

My test environment and software is not precise enough for small
improvements, but I'd say this results in a 10-15 % improvement
(i.e. something like 50 us shorter delay) on the average.

To be sure, one would have to take and print tsc timestamps directly
in the watchdog code, but printk's mess up my timings.

--
Klaus Kusche (Software Development - Control Systems)
KEBA AG Gewerbepark Urfahr, A-4041 Linz, Austria (Europe)
Tel: +43 / 732 / 7090-3120 Fax: +43 / 732 / 7090-6301
E-Mail: kus@xxxxxxxx WWW: www.keba.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/