Re: [PATCH] shrink_list: Use of && instead || leads to unintendedwriting of pages

[Christoph Lameter]

On Thu, 19 Jan 2006, Andrew Morton wrote:

> >  @@ -1512,7 +1512,7 @@ loop_again:
> >   	total_scanned = 0;
> >   	total_reclaimed = 0;
> >   	sc.gfp_mask = GFP_KERNEL;
> >  -	sc.may_writepage = 0;
> >  +	sc.may_writepage = 1;
> >   	sc.may_swap = 1;
> >   	sc.nr_mapped = read_page_state(nr_mapped);
> 
> The balance_pgdat() change is wrong, surely?  We want !laptop_mode.

I did not see any special processing there like in the other place. But 
you could be right.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/