Re: - add-pselect-ppoll-system-call-implementation-tidy.patchremoved from -mm tree

[Stephen Rothwell]

Hi David,

On Thu, 19 Jan 2006 16:21:59 +1100 David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote:
>
> On Wed, 2006-01-18 at 16:52 -0800, akpm@xxxxxxxx wrote:
> > -                       memcpy(&current->saved_sigmask, &sigsaved, sizeof(sigsaved));
> > +                       memcpy(&current->saved_sigmask, &sigsaved,
> > +                                       sizeof(sigsaved));
> 
> I still object to this.
> 
> You justified it on the basis that some people have editors which will
> wrap the original version onto a second line and make it look ugly...
> yet your 'fix' is to wrap it onto a second line and make it look ugly
> for _all_ of us, not just for those using crap editors. I really don't
> see the overall benefit.

Documentation/CodingStyle says:

The limit on the length of lines is 80 columns and this is a hard limit.

Statements longer than 80 columns will be broken into sensible chunks.
Descendants are always substantially shorter than the parent and are placed
substantially to the right. The same applies to function headers with a long
argument list. Long strings are as well broken into shorter strings.

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature