Re: [PATCH 001 of 5] md: Split disks array out of raid5 conf structure so it is easier to grow.

[Neil Brown]

On Tuesday January 17, john@xxxxxxxxxxx wrote:
> >>>>> "NeilBrown" == NeilBrown  <neilb@xxxxxxx> writes:
> 
> NeilBrown> Previously the array of disk information was included in
> NeilBrown> the raid5 'conf' structure which was allocated to an
> NeilBrown> appropriate size.  This makes it awkward to change the size
> NeilBrown> of that array.  So we split it off into a separate
> NeilBrown> kmalloced array which will require a little extra indexing,
> NeilBrown> but is much easier to grow.
> 
> Neil,
> 
> Instead of setting mddev->private = NULL, should you be doing a kfree
> on it as well when you are in an abort state?

The only times I set 
  mddev->private = NULL
it is immediately after
   kfree(conf)
and as conf is the thing that is assigned to mddev->private, this
should be doing exactly what you suggest.

Does that make sense?

NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/