Re: [PATCH] e1000 C style badness

From: Jens Axboe
Date: Wed Jan 18 2006 - 13:18:03 EST


On Wed, Jan 18 2006, Jeff Garzik wrote:
> Jon Smirl wrote:
> >e1000 is failing the same way for me too. Chip is on the motherboard:
> >Intel Corporation 82540EM Gigabit Ethernet Controller (rev 02)
> [...]
> >I am using an old switch so I normally get a half duplex connection:
> >Jan 18 10:14:25 jonsmirl kernel: e1000: eth0: e1000_watchdog_task: NIC
> >Link is Up 100 Mbps Half Duplex
> >I don't normally get the NETDEV up and changed notifications.
>
> e1000 is failing for everybody :( Looks like somewhere in this 40-patch
> behemoth, an "e1000 doesn't work anymore" change slipped in.
>
> We'll get it fixed ASAP, even if it means reverting all those patches.

Thanks, it is rather critical. At least it didn't get included in -rc1,
that would have been a disaster :-)

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/