Re: [RFC] Moving snd-bt87x and btaudio to drivers/media

[Mauro Carvalho Chehab]

Em Qua, 2006-01-18 às 17:25 +0100, Takashi Iwai escreveu:
> At Wed, 18 Jan 2006 11:29:28 -0200,
> Mauro Carvalho Chehab wrote:
> > 

> Which directory do you suppose exactly?  drivers/media/tv (or
> something like that), or existing one like drivers/media/video?
	Better is to be at the same dir as other bttv modules. Currently, it
wil be under drivers/media/video. It seems to me that drivers/media
should be better organized, since lots of shared code between dvb and
v4l are emerging. IMHO, it seems to be a good idea to create a newer dir
to handle chipsets like:
 /drivers/media/chips/
	and include bttv, cx88, em28xx, saa7134 and others as separate dirs
under /chips. This way, it would be easier to detect code duplications
and similarities.
> 
> I personally have no big objection to move snd-bt87x location.
> although the external alsa-driver tarball would require a tune.
> It was there simply because the driver is basically independent from
> other layers but sound.
	True.
>   From the functionality viewpoint, it's better
> to gather all modules, of course.
> 
> One point I'm conerned is, however, the order of objects in the
> built-in kernel.  Recently we had a problem of initializations of
> saa7134-alsa and sound core stuff.  We should be careful about that.
	I've waited to the end of 2.6.16 window to start these discussions to
give us some time to fix compilation order and to realign all necessary
stuff. I think we will have some time until 2.6.17 to prioritize sound
core loading as Linus suggested. There's no rush for such changes.
> 
> Also, more intutive Kconfig would be nice to have.  For example, it'd
> be better to use a choice type for saa7134-alsa and -oss drivers.
> Also, to my eyes, it's better to select CONFIG_SND from saa7134-alsa
> instead of depending on it.
	Agreed. I have already a patch for it to use choice type. I'll work on
it to select CONFIG_SND and CONFIG_SND_PCM.
> 
> 
> Takashi
Cheers, 
Mauro.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/