Re: [discuss] [PATCH/RFC] Unify mapping from PXM to node id.

From: Yasunori Goto
Date: Tue Jan 17 2006 - 19:41:21 EST


> On Tuesday 17 January 2006 13:36, Yasunori Goto wrote:
> > Hello.
> >
> > This patch is to unify mapping from pxm to node id as a common code.
> > In current code, i386, x86-64, and ia64 have its mapping by each own code.
> > But PXM is defined by ACPI and node id is used generically. So,
> > I think there is no reason to define it on each arch's code.
> > This mapping should be written at drivers/acpi/numa.c.
> >
>
> > Please comment.
>
> The array is unnecessary big - PXMs are only 8bit so it could be u8.
>
> Looks ok to me on x86-64 in principle, except that the __devinits should
> be probably __cpuinits. I haven't tested/compiled it though

Ok. I'll modify them, and test it on x86-64 too.
Thanks for your comment.

--
Yasunori Goto


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/