Re: [WATCHDOG] sa1100_wdt.c sparse cleanups

[Wim Van Sebroeck]

Hi Ian,

> On Sat, 2005-11-05 at 10:10 +0000, Russell King wrote:
> 
> > It's probably better to use a union with these, eg:
> 
> The common idiom in the watchdog drivers seems to be to use separate
> variables. I'll leave it up to Wim if he wants to change that.
> 
> The following makes drivers/char/watchdog/sa1100_wdt.c sparse clean.
> 
> Signed-off-by: Ian Campbell <icampbell@xxxxxxxxx>

I seem to have missed this last e-mail (I was moving around that time...).
This is indeed how it's been done in other drivers. I just uploaded this "patch"
into my -mm test tree. Within a week or two I'll move it to the final watchdog tree.

We should look to the struct watchdog part in more detail though.
a union is an option, but probably not the only one :-)

Greetings,
Wim.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/