Re: drivers/block/ps2esdi.c

[Jens Axboe]

On Mon, Jan 16 2006, Randy.Dunlap wrote:
> On Mon, 16 Jan 2006, Alejandro Bonilla Beeche wrote:
> 
> > It looks like the Linux-2.6 tree is still broken...
> >
> > Just FYI
> >
> >
> >   CC      drivers/block/loop.o
> >   CC      drivers/block/ps2esdi.o
> > In file included from drivers/block/ps2esdi.c:42:
> > include/linux/mca-legacy.h:12:2: warning: #warning "MCA legacy - please
> > move your driver to the new sysfs api"
> > drivers/block/ps2esdi.c: In function 'ps2esdi_getgeo':
> > drivers/block/ps2esdi.c:1064: error: dereferencing pointer to incomplete
> > type
> > drivers/block/ps2esdi.c:1065: error: dereferencing pointer to incomplete
> > type
> > drivers/block/ps2esdi.c:1066: error: dereferencing pointer to incomplete
> > type
> > make[3]: *** [drivers/block/ps2esdi.o] Error 1
> > make[2]: *** [drivers/block] Error 2
> > make[1]: *** [drivers] Error 2
> > make[1]: Leaving directory `/root/linux-2.6'
> > make: *** [debian/stamp-build-kernel] Error 2
> > debian:~/linux-2.6#
> 
> As Adrian (IIRC) pointed out last time this was posted (last week),
> this is what you can get when you enable "BROKEN".  IOW, see
>   drivers/block/Kconfig:
> 
> config BLK_DEV_PS2
> 	tristate "PS/2 ESDI hard disk support"
> 	depends on MCA && MCA_LEGACY && BROKEN
>                                         ^^^^^^
> 
> so please send patches to fix it (the driver) if you care about it.

Well this breakage is new though, Christoph looks like fallout from the
geo stuff.

diff --git a/drivers/block/ps2esdi.c b/drivers/block/ps2esdi.c
index 43415f6..bea75f2 100644
--- a/drivers/block/ps2esdi.c
+++ b/drivers/block/ps2esdi.c
@@ -43,6 +43,7 @@
 #include <linux/init.h>
 #include <linux/ioport.h>
 #include <linux/module.h>
+#include <linux/hdreg.h>
 
 #include <asm/system.h>
 #include <asm/io.h>

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/