Re: [PATCH 13/25] cx88 Kconfig fixes for cx88-alsa

[Adrian Bunk]

On Mon, Jan 16, 2006 at 07:11:22AM -0200, mchehab@xxxxxxxxxxxxx wrote:
> 
> From: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>
> 
> - Cx88 alsa is experimental.
> - Removed need of PCM OSS for an ALSA module.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>
> ---
> 
>  drivers/media/video/cx88/Kconfig |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/video/cx88/Kconfig b/drivers/media/video/cx88/Kconfig
> index 76fcb4e..5330891 100644
> --- a/drivers/media/video/cx88/Kconfig
> +++ b/drivers/media/video/cx88/Kconfig
> @@ -31,8 +31,7 @@ config VIDEO_CX88_DVB
>  
>  config VIDEO_CX88_ALSA
>  	tristate "ALSA DMA audio support"
> -	depends on VIDEO_CX88 && SND
> -	select SND_PCM_OSS
> +	depends on VIDEO_CX88 && SND && EXPERIMENTAL
>  	---help---
>  	  This is a video4linux driver for direct (DMA) audio on
>  	  Conexant 2388x based TV cards.

This patch introduces a bug.

While select'ing SND_PCM_OSS isn't required, SND_PCM must be select'ed.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/