Re: [PATCH] INPUT: add MODALIAS to the event environment

From: Kay Sievers
Date: Sat Jan 14 2006 - 06:02:46 EST


On Sat, Jan 14, 2006 at 10:14:00AM +0500, Alexander E. Patrakov wrote:
> Greg KH wrote:
> >[PATCH] INPUT: add MODALIAS to the event environment
> >
> >input: add MODALIAS to the event environment
>
> Could you please tell me sample modaliases for a number of "common"
> devices (like a PS/2 mouse)?
>
> I ask because earlier (namely, in
> http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/old/gregkh-all-2.6.15.patch)
> such modaliases contained commas (",") and comma is not a "trusted"
> character in Udev (see replace_untrusted_chars() in udev_utils_string.c).
> Thus, such modaliases were mangled and didn't work.

Only if you read it with $sysfs{modalias}, it's available in $env{MODALIAS}
and does not get mangled there, right? If you have problems with that,
let us know and we will fix it.

(We can't trust the values of some sysfs files to be passed to external
programs or directly used to create a device node name, cause some of
them are directly copied from a device property.)

Thanks,
Kay
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/