Re: [PATCH] - pci_ids - adding pci device id support for FC949ES

[Christoph Hellwig]

On Fri, Jan 13, 2006 at 12:03:23AM -0800, Andrew Morton wrote:
> >  --- b/include/linux/pci_ids.h	2006-01-11 19:04:18.000000000 -0700
> >  +++ a/include/linux/pci_ids.h	2006-01-12 14:19:43.000000000 -0700
> >  @@ -181,6 +181,7 @@
> >   #define PCI_DEVICE_ID_LSI_FC929X	0x0626
> >   #define PCI_DEVICE_ID_LSI_FC939X	0x0642
> >   #define PCI_DEVICE_ID_LSI_FC949X	0x0640
> >  +#define PCI_DEVICE_ID_LSI_FC949ES	0x0646
> >   #define PCI_DEVICE_ID_LSI_FC919X	0x0628
> >   #define PCI_DEVICE_ID_NCR_YELLOWFIN	0x0701
> >   #define PCI_DEVICE_ID_LSI_61C102	0x0901
> 
> That doesn't add support - it just adds the ID.  We've apparently decided
> not to keep IDs of devices which the kernel doesn't support.

There's a patch on linux-scsi that adds the actual support.

> Also, there's a plan to stop using pci_ids.h - PCI IDs are supposed to go
> into a driver-private header file.  I guess drivers/scsi/megaraid.h is an
> example.

That's new to me.  In either case a single driver should do one thing
consistantly, and fusion has tons of defines in pci_ids.h already.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/