Re: [PATCH 15/15] kconf: Check for eof from input stream.

[Roman Zippel]

Hi,

On Wed, 11 Jan 2006, Ben Collins wrote:

> First, we need oldconfig because it allows us to look at the build log
> and see exactly what happened in the config stage. Silentoldconfig gives
> us no feedback for logs.

silentoldconfig gives you exactly the same information. Both conf and 
oldconfig will change invisible options without telling you, so it's not 
exact at all.
If you can't trust a silent oldconfig, a more verbose oldconfig can't tell 
you anything else, if it would it's a bug.

> 3) Obviously since current behavior of oldconfig was broken with a
> closed stdin, then it was never doing what anyone wanted in this usage
> case. Since no one else noticed it, that means that we are the only use
> case for this.

This is enough reason to simply hijack conf and use it for your own 
purpose without even asking the maintainer about the intended bahaviour?

> 5) My patch did not break anything, nor did it change anything that was
> already working.

It _was_ working like that, you're breaking it.

> 6) In response you make oldconfig work exactly opposite of
> silentoldconfig by using the default value for a config option when
> stdin is closed (basically acting like the user hit ENTER), and further
> break things for me in this usage case, with no purpose, and no reason
> for making your change the way you did. Since it was broken, you aren't
> helping anyone. We can't have the build system using default values. We
> need it to abort.

So simply use silentoldconfig.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/