Re: [PATCH 09/20] V4L/DVB (3344d) Stradis video little cleanup

From: Andrew Morton
Date: Wed Jan 11 2006 - 22:52:52 EST


mchehab@xxxxxxxxxxxxx wrote:
>
> +errosd:
> + vfree(saa->osdbuf);
> + saa->osdbuf = NULL;
> +erraud:
> + vfree(saa->audbuf);
> + saa->audbuf = NULL;
> +errvid:
> + vfree(saa->vidbuf);
> + saa->vidbuf = NULL;
> +err:
> + return -ENOMEM;
> }

vfree(NULL) is legal, so this could be:

error:
vfree(saa->osdbuf);
vfree(saa->audbuf);
vfree(saa->vidbuf);
saa->vidbuf = NULL;
saa->osdbuf = NULL;
saa->audbuf = NULL;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/