Re: 2.6.15-git7 oopses in ext3 during LTP runs

[Ingo Molnar]

* David S. Miller <davem@xxxxxxxxxxxxx> wrote:

> From: Pavel Machek <pavel@xxxxxxx>
> Date: Wed, 11 Jan 2006 23:40:13 +0100
> 
> > likely is the evil part here. What about this? Should make this bug
> > impossible to do....
> > 
> > Signed-off-by: Pavel Machek <pavel@xxxxxxx>
> 
> This doesn't let you do:
> 
>      if (likely(y) || unlikely(x))

hm, why not? It will expand to:

   if ((__builtin_expect(!!(y), 1)) || (__builtin_expect(!!(x), 0)))

which seems correct to me. Pavel only added extra parantheses, to make 
the simple case more readable.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/