Re: [PATCH 5/5] Direct Migration V9: Avoid writeback /page_migrate() method

[Andrew Morton]

Christoph Lameter <clameter@xxxxxxx> wrote:
>
> +	spin_lock(&mapping->private_lock);
>  +
>  +	bh = head;
>  +	do {
>  +		get_bh(bh);
>  +		lock_buffer(bh);
>  +		bh = bh->b_this_page;
>  +
>  +	} while (bh != head);
>  +

Guys, lock_buffer() sleeps and cannot be called inside spinlock.

Please, always enable kernel preemption and all debug options when testing
your code.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/