Re: [PATCH] HPET RTC emulation: add watchdog timer

[Clemens Ladisch]

Andi Kleen wrote:
> Clemens Ladisch <lkml@xxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > Andi Kleen wrote:
> > > Clemens Ladisch wrote:
> > > > To prevent the emulated RTC timer from stopping when
> > > > interrupts are disabled for too long, implement the watchdog
> > > > timer to restart it when needed.
> > >
> > > The interrupt handler should just read the time (it likely
> > > has to do that anyways)
> >
> > Not in the current implementation.
>
> The standard HPET interrupt in x86-64 does this already at least.

But it's slower than just doing a mod_timer which the RTC code does
_anyway_, so we could just as well use it.  Especially as the watchdog
timer isn't actually expected to run in normal circumstances.


Clemens

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/