Re: [PATCH] It's UTF-8

From: Måns Rullgård
Date: Sun Jan 08 2006 - 17:08:00 EST


Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> writes:

>>Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
>
> I'd say ACK. However,
>
>> iocharset=name Character set to use for converting from Unicode to
>> ASCII. The default is to do no conversion. Use
>>- iocharset=utf8 for UTF8 translations. This requires
>>+ iocharset=utf8 for UTF-8 translations. This requires
>> CONFIG_NLS_UTF8 to be set in the kernel .config file.
>
> If you are really nitpicky about the "-", then it should also be
> "iocharset=utf-8" (and whereever else). Or what's the real purpose of
> adding the dashes in only half of the places, then?

The patch only changes documentation/comments. Changing other things
would break compatibility, and that's usually not a good idea for
cosmetic changes.

--
Måns Rullgård
mru@xxxxxxxxxxxxx

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/