[patch 2.6.15 v2] Tell kallsyms_lookup_name() to ignore type U entries

From: Keith Owens
Date: Sat Jan 07 2006 - 22:11:20 EST


When one module exports a function symbol and another module uses that
symbol then kallsyms shows the symbol twice. Once from the consumer
with a type of 'U' and once from the provider with a type of 't' or
'T'. On most architectures, both entries have the same address so it
does not matter which one is returned by kallsyms_lookup_name(). But
on architectures with function descriptors, the 'U' entry points to the
descriptor, not to the code body, which is not what we want.

IA64 # grep -w qla2x00_remove_one /proc/kallsyms
a000000208c25ef8 U qla2x00_remove_one [qla2300] <= descriptor
a000000208bf44c0 t qla2x00_remove_one [qla2xxx] <= function body

Tell kallsyms_lookup_name() to ignore type U entries in modules.

Signed-off-by: Keith Owens <kaos@xxxxxxx>

---

module.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

Index: linux/kernel/module.c
===================================================================
--- linux.orig/kernel/module.c 2006-01-06 12:58:52.841135060 +1100
+++ linux/kernel/module.c 2006-01-06 12:59:03.438308825 +1100
@@ -2050,7 +2050,8 @@ static unsigned long mod_find_symname(st
unsigned int i;

for (i = 0; i < mod->num_symtab; i++)
- if (strcmp(name, mod->strtab+mod->symtab[i].st_name) == 0)
+ if (strcmp(name, mod->strtab+mod->symtab[i].st_name) == 0 &&
+ mod->symtab[i].st_info != 'U')
return mod->symtab[i].st_value;
return 0;
}


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/