Re: [PATCH -mm 1/2] swsusp: low level interface

From: Rafael J. Wysocki
Date: Sat Jan 07 2006 - 08:54:58 EST


On Saturday, 7 January 2006 14:20, Andrew Morton wrote:
> "Rafael J. Wysocki" <rjw@xxxxxxx> wrote:
> >
> > This patch introduces the low level interface that can be used for handling
> > the snapshot of the system memory by the in-kernel swap-writing/reading
> > code of swsusp and the userland interface code (to be introduced shortly).
>
> It's a bit sad the way this code goes poking around in swap internals.

Actually swsusp does it anyway ...

> Would it be neater to create a few helper functions over in mm/ and call
> them?

... but of course it can be changed as you say. I'll try to prepare something
like that.

> This patch needs pretty much all of its inlines removed. It's way over the
> top.

I'll fix that.

Rafael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/