Re: [2.6 patch] fix arm26 THREAD_SIZE

From: Ian Molton
Date: Fri Jan 06 2006 - 19:35:36 EST


Adrian Bunk wrote:

Looks good to me. cant recall why that got that way, but the div by zero definately went away at the time. certainly its wrong as-is, the implication is that an 8 MB machine would get a max_threads of about 4 :)

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
Signed-off-by: Ian Molton <spyro@xxxxxxx>

--- linux-2.6.15-mm1-full/include/asm-arm26/thread_info.h.old 2006-01-06 16:45:40.000000000 +0100
+++ linux-2.6.15-mm1-full/include/asm-arm26/thread_info.h 2006-01-06 16:46:07.000000000 +0100
@@ -80,8 +80,7 @@
return (struct thread_info *)(sp & ~0x1fff);
}

-/* FIXME - PAGE_SIZE < 32K */
-#define THREAD_SIZE (8*32768) // FIXME - this needs attention (see kernel/fork.c which gets a nice div by zero if this is lower than 8*32768
+#define THREAD_SIZE PAGE_SIZE
#define task_pt_regs(task) ((struct pt_regs *)(task_stack_page(task) + THREAD_SIZE - 8) - 1)

extern struct thread_info *alloc_thread_info(struct task_struct *task);



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/