[patch 2/4] fix input layer f_ops abuse

From: Arjan van de Ven
Date: Fri Jan 06 2006 - 16:51:12 EST


From: Arjan van de Ven <arjan@xxxxxxxxxxxxx>

The input layer has an assignment to a live ->fops, just after creating the
fops as a duplicate of another one. Just move this assignment a few lines up to avoid
the race and the assignment to a live fops

Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxxxxx>
drivers/input/input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.15/drivers/input/input.c
===================================================================
--- linux-2.6.15.orig/drivers/input/input.c
+++ linux-2.6.15/drivers/input/input.c
@@ -478,8 +478,8 @@ static int __init input_proc_init(void)

entry->owner = THIS_MODULE;
input_fileops = *entry->proc_fops;
+ input_fileops.poll = input_devices_poll;
entry->proc_fops = &input_fileops;
- entry->proc_fops->poll = input_devices_poll;

entry = create_proc_read_entry("handlers", 0, proc_bus_input_dir, input_handlers_read, NULL);
if (!entry)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/