Re: [PATCH] slab: Adds missing kmalloc() checks.

From: Luiz Fernando Capitulino
Date: Fri Jan 06 2006 - 10:30:00 EST


On Fri, 06 Jan 2006 16:24:47 +0100
Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

| On Fri, 2006-01-06 at 13:12 -0200, Luiz Fernando Capitulino wrote:
| > Adds two missing kmalloc() checks in kmem_cache_init(). Note that if the
| > allocation fails, there is nothing to do, so we panic();
|
| ok so what good does this do? if you die this early.. you are in deeper
| problems, and can't boot. while this makes the code bigger...

Well, you'll get a panic with a message saying you have no memory to
boot, instead of a OOPS with a kernel NULL pointer derefecence, which
will make you look for a bug.

--
Luiz Fernando N. Capitulino
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/