Re: [PATCH 4/6] sysctl: dont overflow the user-supplied buffer with0

From: Linus Torvalds
Date: Thu Jan 05 2006 - 20:30:18 EST




On Thu, 5 Jan 2006, Chris Wright wrote:
>
> If the string was too long to fit in the user-supplied buffer,
> the sysctl layer would zero-terminate it by writing past the
> end of the buffer. Don't do that.

Don't use this one. It doesn't zero-pad the string if the result buffer is
too small (which _could_ cause problems) and it actually returns the wrong
length too.

There's a better one in the final 2.6.15.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/