Re: [ckrm-tech] Re: [PATCH 00/01] Move Exit Connectors

From: Matt Helsley
Date: Thu Jan 05 2006 - 19:11:30 EST


On Thu, 2006-01-05 at 15:10 -0800, Andrew Morton wrote:
> Matt Helsley <matthltc@xxxxxxxxxx> wrote:
> >
> > This patch moves both the process exit event and per-process stats
> > connectors above exit_mm() since the latter needs values from the
> > mm_struct which will be lost after exit_mm().
> >
> > Signed-off-by: Matt Helsley <matthltc@xxxxxxxxxx>
> >
> > --
> >
> > Index: linux-2.6.15/kernel/exit.c
> > ===================================================================
> > --- linux-2.6.15.orig/kernel/exit.c
> > +++ linux-2.6.15/kernel/exit.c
> > @@ -845,10 +845,14 @@ fastcall NORET_TYPE void do_exit(long co
> > if (group_dead) {
> > del_timer_sync(&tsk->signal->real_timer);
> > exit_itimers(tsk->signal);
> > acct_process(code);
> > }
> > +
> > + tsk->exit_code = code;
> > + proc_exit_connector(tsk);
> > + cnstats_exit_connector(tsk);
>
> cnstats_exit_connector() doesn't exist yet...

Right. I forgot to repeat what I mentioned in the parent email -- that
this patch is intended to be applied on top of Shailabh's patches.

The first patch I posted (01/01) is intended for plain 2.6.15. Before
proposing 01/01 for -mm I've been trying to see if there are any
problems with the value of tsk->exit_signal before exit_mm() -- hence
the "[RFC]" in the subject line of that one.

Thanks,
-Matt Helsley

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/